❗BREAKING CHANGE❗️Ensure compatibility with graphql-php v15 #953

mfn · 2022-10-15T18:11:07Z

Summary

See webonyx/graphql-php#1231

❗ Merging this will require a major version bump due to all around incompatible changes forced by graphql-php ❗

TODO

Figure out how to fix or workaround the disabled test \Rebing\GraphQL\Tests\Unit\ConfigTest::testSecurity
Wait for official v15 release and remove hack commit "graphql-php-v15: workaround to allow testing with graphql-php v15"
Then make sure integration tests are green
They current aren't due to the composer.json hack

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

Existing tests have been adapted and/or new tests have been added
Add a CHANGELOG.md entry
Update the README.md
Code style has been fixed via composer fix-style

spawnia · 2022-10-18T10:01:23Z

composer.json

@@ -38,9 +38,9 @@
        "ext-json": "*",
        "illuminate/contracts": "^6.0|^8.0|^9.0",
        "illuminate/support": "^6.0|^8.0|^9.0",
-        "laragraph/utils": "^1",
+        "laragraph/utils": "1.4.1",


Suggested change

"laragraph/utils": "1.4.1",

"laragraph/utils": "dev-graphql-php-15",

Should be the easier temporary fix.

Oh my… I never connected the dots, that what follows dev-… can be any qualifier, even a branch name 🤦🏼

Nice, thanks, everything is green!

A later commit adds support back for our own error classes.

…y for our own error classes

…sses

…ack to payload

The ability to internally prepend the graphql-php namespace was removed [1]. [1] webonyx/graphql-php@d36e809#diff-fa0403de31548d680d863a100fdc906ec53696abb9d1e8b0cbc92020b7cce9a2L255

…e()`

Until we figure out what the replacement for the getter is

…ReadOnly` have been dropped in favour of the public properties

This reverts commit 86f2ded.

# Conflicts: # phpstan.neon.dist

…t key name

# Conflicts: # CHANGELOG.md # composer.json

…aphql-php 15

leonardocustodio · 2023-01-27T12:41:30Z

We are having this issue when running tests on PHP 8.2, I guess because rebing is still using the older webonyx lib?

PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /vendor/webonyx/graphql-php/src/Validator/Rules/ValuesOfCorrectType.php on line 182

mfn · 2023-01-27T14:26:36Z

Yes, this sounds about right; and this PR would fix this.

websitevirtuoso · 2023-02-16T18:21:57Z

v15 has been released
https://github.com/webonyx/graphql-php/releases
Can we check this PR one more time please?
Let me know If I can assist in this

sforward · 2023-03-01T10:47:14Z

I have been testing these changes against our tests. I'm running into an exception when printing the generated schema via the upstream GraphQL\Utils\SchemaPrinter::doPrint. I've made a test case and a solution, but not sure if that's the best solution:

0fc11f6

mfn · 2023-03-01T11:18:05Z

Cool find @sforward ! Can you make a PR against master with just the test?

Assuming it would just work, next time I rebase this PR I'll then fix it considering your suggestion in the commit.

WDYT?

sforward · 2023-03-01T18:28:03Z

Sure, I've created a MR with the test!

# Conflicts: # .github/workflows/tests.yml # CHANGELOG.md # composer.json # phpstan-baseline.neon # phpstan.neon.dist # tests/Unit/GraphQLTest.php

mfn · 2023-03-05T07:31:19Z

I have been testing these changes against our tests. I'm running into an exception when printing the generated schema via the upstream GraphQL\Utils\SchemaPrinter::doPrint. I've made a test case and a solution, but not sure if that's the best solution:

This seems to be related to the recent change in webonyx/graphql-php#1303 . If I revert these changes in SchemaPrinter.php, the test passes.

Not yet sure what the expectation is here.

mfn · 2023-03-05T14:34:54Z

@sforward I came up with an alternate fix: it seems the change in graphql-php now expects the lazy type loader to also answer for the top level Mutation (etc.) types, which no one ever realized because no one needed it.

I've added them in the latest commit but also opened webonyx/graphql-php#1336 to see if that's actually intentional.

mfn self-assigned this Oct 15, 2022

mfn force-pushed the mp-graphql-php-v15 branch 2 times, most recently from ec0da08 to bf2668a Compare October 17, 2022 19:48

mfn changed the title ~~Ensure compatibility with graphql-php 15~~ Ensure compatibility with graphql-php v15 Oct 17, 2022

mfn force-pushed the mp-graphql-php-v15 branch from bf2668a to d8469da Compare October 17, 2022 20:01

spawnia reviewed Oct 18, 2022

View reviewed changes

mfn added 15 commits October 18, 2022 14:13

graphql-php-v15: workaround to allow testing with graphql-php v15

1d4eea9

graphql-php-v15: adding property types due to upstream changes

17096de

graphql-php-v15: adapt for file/line/trace changes

5702767

graphql-php-v15: category as provided by graphql-php has been removed

bbeb9b1

A later commit adds support back for our own error classes.

graphql-php-v15: add interface to provide errors.*.extensions.categor…

e5a5337

…y for our own error classes

graphql-php-v15: use new ProvidesErrorCategory interface on error cla…

f5f46c9

…sses

graphql-php-v15: check for ProvidesErrorCategory and add category b…

5fcd96a

…ack to payload

graphql-php-v15: adapt for changed location of debugMessage

c8c61ea

graphql-php-v15: use FCQN now instead only the class name

0124fd4

The ability to internally prepend the graphql-php namespace was removed [1]. [1] webonyx/graphql-php@d36e809#diff-fa0403de31548d680d863a100fdc906ec53696abb9d1e8b0cbc92020b7cce9a2L255

graphql-php-v15: replace getWrappedType(true) with `getInnermostTyp…

363f321

…e()`

graphql-php-v15: adjust for changed error message

da2fde4

graphql-php-v15: temporarily skip test

86f2ded

Until we figure out what the replacement for the getter is

graphql-php-v15: OperationParams methods getOriginalInput and `is…

a911604

…ReadOnly` have been dropped in favour of the public properties

graphql-php-v15: adapt phpstan config

ebd843a

graphql-php-v15: adapt phpstan baseline

c01f88d

mfn force-pushed the mp-graphql-php-v15 branch from 5d06f71 to c01f88d Compare October 18, 2022 12:13

mfn added 7 commits October 21, 2022 13:15

Revert "graphql-php-v15: temporarily skip test"

38c518d

This reverts commit 86f2ded.

Merge branch 'master' into mp-graphql-php-v15

5c702e3

# Conflicts: # phpstan.neon.dist

graphql-php-v15: switch composer version to 15

5415db9

graphql-php-v15: fix rename of FieldArgument and arg requires explici…

9297b5c

…t key name

Merge branch 'master' into mp-graphql-php-v15

5a54bf7

graphql-php-v15: update phpstan baseline

027d590

graphql-php-v15: composer fix-style

9f97bf6

mfn force-pushed the mp-graphql-php-v15 branch from da4bcd1 to 82d13d1 Compare January 7, 2023 11:39

mfn mentioned this pull request Jan 13, 2023

Support webonyx/graphql-php:^15 laragraph/utils#4

Merged

mfn added 2 commits January 13, 2023 11:15

Merge branch 'master' into mp-graphql-php-v15

4a93cde

# Conflicts: # CHANGELOG.md # composer.json

graphql-php-v15: switch to laragraph/utils release also supporting gr…

0cd9ceb

…aphql-php 15

mfn mentioned this pull request Jan 13, 2023

❗BREAKING CHANGE❗️ Remove optional support for non-lazy loading of types #966

Merged

9 tasks

mfn force-pushed the mp-graphql-php-v15 branch from 3bfa578 to 82c14c1 Compare January 13, 2023 11:07

graphql-php-v15: include a more detailed BC changelog

503a966

mfn force-pushed the mp-graphql-php-v15 branch from 82c14c1 to 503a966 Compare January 13, 2023 11:07

jasonvarga mentioned this pull request Jan 18, 2023

PHP 8.2 statamic/cms#7299

Merged

zabavnikov mentioned this pull request Jan 24, 2023

Parameters passed to lookAheаd are not applied #818

Closed

tm1000 approved these changes Jan 27, 2023

View reviewed changes

mfn mentioned this pull request Feb 25, 2023

chore(deps): update webonyx/graphql-php requirement from ^14.6.4 to ^14.6.4 || ^15.0.0 #993

Closed

sforward mentioned this pull request Mar 1, 2023

Add test to ensure support for schema printer #995

Merged

9 tasks

Merge branch 'master' into mp-graphql-php-v15

88b04d2

# Conflicts: # .github/workflows/tests.yml # CHANGELOG.md # composer.json # phpstan-baseline.neon # phpstan.neon.dist # tests/Unit/GraphQLTest.php

graphql-php-v15: adapt phpstan after merge with master

5e09d34

mfn force-pushed the mp-graphql-php-v15 branch from 3be4dfe to 5e09d34 Compare March 5, 2023 10:35

mfn added 2 commits March 5, 2023 12:01

Merge branch 'master' into mp-graphql-php-v15

4eb3da7

graphql-php-v15: also resolve our top level types

39c5ca9

mfn linked an issue Mar 5, 2023 that may be closed by this pull request

Using getRelations of SelectFields involves only selecting the requested fields for relationships #980

Closed

mfn mentioned this pull request Mar 5, 2023

Don't unnecessarily invoke type loader when printing schema webonyx/graphql-php#1336

Closed

mfn mentioned this pull request Mar 5, 2023

Branch / PR to integrate all breaking changes for release 9 #997

Merged

mfn merged commit af54a0f into master Mar 5, 2023

mfn deleted the mp-graphql-php-v15 branch June 26, 2023 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

❗BREAKING CHANGE❗️Ensure compatibility with graphql-php v15 #953

❗BREAKING CHANGE❗️Ensure compatibility with graphql-php v15 #953

mfn commented Oct 15, 2022 •

edited

Loading

spawnia Oct 18, 2022

mfn Oct 18, 2022

mfn Oct 18, 2022

leonardocustodio commented Jan 27, 2023

mfn commented Jan 27, 2023

websitevirtuoso commented Feb 16, 2023

sforward commented Mar 1, 2023

mfn commented Mar 1, 2023

sforward commented Mar 1, 2023

mfn commented Mar 5, 2023

mfn commented Mar 5, 2023

	"laragraph/utils": "1.4.1",
	"laragraph/utils": "dev-graphql-php-15",

❗BREAKING CHANGE❗️Ensure compatibility with graphql-php v15 #953

❗BREAKING CHANGE❗️Ensure compatibility with graphql-php v15 #953

Conversation

mfn commented Oct 15, 2022 • edited Loading

Summary

TODO

spawnia Oct 18, 2022

Choose a reason for hiding this comment

mfn Oct 18, 2022

Choose a reason for hiding this comment

mfn Oct 18, 2022

Choose a reason for hiding this comment

leonardocustodio commented Jan 27, 2023

mfn commented Jan 27, 2023

websitevirtuoso commented Feb 16, 2023

sforward commented Mar 1, 2023

mfn commented Mar 1, 2023

sforward commented Mar 1, 2023

mfn commented Mar 5, 2023

mfn commented Mar 5, 2023

mfn commented Oct 15, 2022 •

edited

Loading